Implement V2 registration support

.typos.toml

@@ -14,8 +14,10 @@ extend-ignore-re = [
     # In SMTP it's called HELO, so ignore it
     "(?i)helo_name",
     "Server name sent during.+HELO",
-    # COSE Is short for CBOR Object Signing and Encryption
-    "(?i)cose",
+    # COSE Is short for CBOR Object Signing and Encryption, ignore these specific items
+    "COSE",
+    "COSEKey",
+    "COSEAlgorithm",
     # Ignore this specific string as it's valid
     "Ensure they are valid OTPs",
     # This word is misspelled upstream

migrations/mysql/2026-09-19-120000_cipher_data_longtext/up.sql

@@ -1,3 +0,0 @@
--- A blob-encrypted cipher keeps all of its content in `data`, up to 500,000 characters, so the
--- 64 KiB of TEXT is too small. Like upstream, which uses LONGTEXT.
-ALTER TABLE ciphers MODIFY data LONGTEXT NOT NULL;

migrations/postgresql/2026-09-19-120000_cipher_data_longtext/up.sql

@@ -1 +0,0 @@
--- TEXT has no size limit here, only MySQL needed the change

migrations/sqlite/2026-09-19-120000_cipher_data_longtext/up.sql

@@ -1 +0,0 @@
--- TEXT has no size limit here, only MySQL needed the change

src/api/core/accounts.rs

@@ -203,21 +203,17 @@ struct KeysData {
     public_key: String,
 }
 
-/// Upstream's implicit `[Required]` on a non-nullable string: present and not blank.
-fn required(value: Option<String>, field: &str) -> ApiResult<String> {
-    match value {
-        Some(value) if !value.trim().is_empty() => Ok(value),
-        _ => err!(format!("The {field} field is required.")),
-    }
-}
-
-/// The `accountKeys` payload: a v1 key pair, or v2 with a signature key pair and security state.
+/// The `accountKeys` payload, which replaces the flat `keys`/`userAsymmetricKeys` object.
 ///
-/// Ref: <https://github.com/bitwarden/server/blob/9030c42bf7d8f9ac2ff9fee85c39588d5eb81499/src/Core/KeyManagement/Models/Api/Request/AccountKeysRequestModel.cs#L6-L50>
+/// It carries either a "v1" state (just the encryption key pair) or a "v2" one, which adds a
+/// signature key pair, a signed public key, and a signed security state. The two deprecated
+/// top-level fields are still sent by the SDK alongside the nested ones and are only used as a
+/// fallback for clients that don't send `publicKeyEncryptionKeyPair` yet.
+///
+/// Ref: <https://github.com/bitwarden/server/blob/main/src/Core/KeyManagement/Models/Api/Request/AccountKeysRequestModel.cs>
 #[derive(Debug, Deserialize)]
 #[serde(rename_all = "camelCase")]
-struct AccountKeysData {
-    // Required like upstream, but only used without `public_key_encryption_key_pair`
+pub struct AccountKeysData {
     user_key_encrypted_account_private_key: Option<String>,
     account_public_key: Option<String>,
 
@@ -249,7 +245,7 @@ struct SecurityStateData {
     security_version: i32,
 }
 
-struct ValidatedAccountKeys {
+pub struct ValidatedAccountKeys {
     private_key: String,
     public_key: String,
     v2: Option<ValidatedV2AccountKeys>,
@@ -265,37 +261,25 @@ struct ValidatedV2AccountKeys {
 }
 
 impl AccountKeysData {
-    /// Upstream's model checks, plus the v2 fields all or none: no client can unlock a partial v2 state.
-    fn validate(self) -> ApiResult<ValidatedAccountKeys> {
-        let top_private_key =
-            required(self.user_key_encrypted_account_private_key, "UserKeyEncryptedAccountPrivateKey")?;
-        let top_public_key = required(self.account_public_key, "AccountPublicKey")?;
-        let (private_key, public_key, signed_public_key) = match self.public_key_encryption_key_pair {
-            Some(key_pair) => (
-                required(Some(key_pair.wrapped_private_key), "WrappedPrivateKey")?,
-                required(Some(key_pair.public_key), "PublicKey")?,
-                key_pair.signed_public_key,
-            ),
-            // Older clients only send the top-level fields, which are always v1
-            None => (top_private_key, top_public_key, None),
+    /// Checks that the payload describes a complete account cryptographic state.
+    ///
+    /// The v2 fields have to be all present or all absent: a client that receives a COSE-wrapped
+    /// private key without the matching signature key pair and security state refuses to unlock the
+    /// vault, so storing half a state would produce an account nobody can log into.
+    pub fn validate(self) -> ApiResult<ValidatedAccountKeys> {
+        let (private_key, public_key, signed_public_key) = if let Some(key_pair) = self.public_key_encryption_key_pair {
+            (key_pair.wrapped_private_key, key_pair.public_key, key_pair.signed_public_key)
+        // Older clients only send the deprecated top-level fields, which are always v1.
+        } else if let (Some(private_key), Some(public_key)) =
+            (self.user_key_encrypted_account_private_key, self.account_public_key)
+        {
+            (private_key, public_key, None)
+        } else {
+            err!("The account keys are missing an encryption key pair")
         };
 
-        if let Some(signature_key_pair) = &self.signature_key_pair {
-            required(Some(signature_key_pair.signature_algorithm.clone()), "SignatureAlgorithm")?;
-            required(Some(signature_key_pair.wrapped_signing_key.clone()), "WrappedSigningKey")?;
-            required(Some(signature_key_pair.verifying_key.clone()), "VerifyingKey")?;
-        }
-        if let Some(security_state) = &self.security_state {
-            required(Some(security_state.security_state.clone()), "SecurityState")?;
-            if security_state.security_state.encode_utf16().count() > 10_000 {
-                err!("The field SecurityState must be a string with a maximum length of 10000.")
-            }
-        }
-
         let v2 = match (signed_public_key, self.signature_key_pair, self.security_state) {
             (Some(signed_public_key), Some(signature_key_pair), Some(security_state)) => {
-                // Upstream fails on a null one, but takes an empty one that no client can unlock with
-                let signed_public_key = required(Some(signed_public_key), "SignedPublicKey")?;
                 let Some(signature_algorithm) = SignatureAlgorithm::parse(&signature_key_pair.signature_algorithm)
                 else {
                     err!(format!(
@@ -338,28 +322,28 @@ impl From<KeysData> for ValidatedAccountKeys {
 }
 
 impl ValidatedAccountKeys {
-    /// The keys of a registration: `accountKeys` only for a v2 account, like upstream.
-    ///
-    /// Ref: <https://github.com/bitwarden/server/blob/9030c42bf7d8f9ac2ff9fee85c39588d5eb81499/src/Core/Auth/Models/Api/Request/Accounts/RegisterFinishRequestModel.cs#L77-L100>
-    fn for_registration(account_keys: Option<AccountKeysData>, keys: Option<KeysData>) -> ApiResult<Self> {
-        if let Some(account_keys) = account_keys {
-            let account_keys = account_keys.validate()?;
-            if account_keys.is_v2() {
-                return Ok(account_keys);
-            }
+    /// The keys of a request that may carry either shape. `accountKeys` supersedes the flat `keys`
+    /// object when both are sent.
+    fn from_request(account_keys: Option<AccountKeysData>, keys: Option<KeysData>) -> ApiResult<Option<Self>> {
+        match (account_keys, keys) {
+            (Some(account_keys), _) => account_keys.validate().map(Some),
+            (None, keys) => Ok(keys.map(Self::from)),
         }
-        let Some(keys) = keys else {
-            err!("PublicKey and WrappedPrivateKey not found in RequestModel")
-        };
-        Ok(keys.into())
     }
 
     fn is_v2(&self) -> bool {
         self.v2.is_some()
     }
 
-    /// Sets the keys on the user, which then needs saving before [`Self::save_signature_key_pair`].
-    fn apply(&self, user: &mut User) -> EmptyResult {
+    /// Writes the parts of the state that live on the user itself. The user still needs saving, and
+    /// [`Self::save_signature_key_pair`] still needs calling once it has been.
+    ///
+    /// Rejects downgrading an account from v2 back to v1.
+    pub fn apply(&self, user: &mut User) -> EmptyResult {
+        if user.is_v2() && self.v2.is_none() {
+            err!("Cannot downgrade an account from v2 to v1 encryption")
+        }
+
         user.private_key = Some(self.private_key.clone());
         user.public_key = Some(self.public_key.clone());
 
@@ -370,8 +354,9 @@ impl ValidatedAccountKeys {
         Ok(())
     }
 
-    /// Saves the signature key pair, which needs the user to exist for its foreign key.
-    async fn save_signature_key_pair(&self, user_id: &UserId, conn: &DbConn) -> EmptyResult {
+    /// Persists the signature key pair. Separate from [`Self::apply`] because the row has a foreign
+    /// key to the user, so it can only be written once the user exists.
+    pub async fn save_signature_key_pair(&self, user_id: &UserId, conn: &DbConn) -> EmptyResult {
         // Skip if the account is v1, since v1 accounts don't have a signature key pair.
         let Some(v2) = &self.v2 else {
             return Ok(());
@@ -542,7 +527,7 @@ pub async fn register(data: Json<RegisterData>, conn: DbConn) -> JsonResult {
     // the user can retry without losing their invitation below.
     let password_hint = clean_password_hint(data.master_password_hint.as_ref());
     enforce_password_hint_setting(password_hint.as_ref())?;
-    let account_keys = ValidatedAccountKeys::for_registration(data.account_keys, data.keys)?;
+    let account_keys = ValidatedAccountKeys::from_request(data.account_keys, data.keys)?;
 
     let mut user = match User::find_by_mail(&email, &conn).await {
         Some(user) => {
@@ -599,10 +584,13 @@ pub async fn register(data: Json<RegisterData>, conn: DbConn) -> JsonResult {
         user.name = name;
     }
 
-    account_keys.apply(&mut user)?;
-    // Like upstream, only a v2 registration records the key id; v1 accounts report it through `user-key-id`
-    if account_keys.is_v2() {
-        user.key_id = data.compat.key_id();
+    if let Some(ref account_keys) = account_keys {
+        account_keys.apply(&mut user)?;
+        // Like upstream, only a v2 registration records the user key id. A v1 account reports it
+        // later, through `user-key-id`.
+        if account_keys.is_v2() {
+            user.key_id = data.compat.key_id();
+        }
     }
 
     if email_verified {
@@ -625,7 +613,10 @@ pub async fn register(data: Json<RegisterData>, conn: DbConn) -> JsonResult {
     }
 
     user.save(&conn).await?;
-    account_keys.save_signature_key_pair(&user.uuid, &conn).await?;
+
+    if let Some(account_keys) = account_keys {
+        account_keys.save_signature_key_pair(&user.uuid, &conn).await?;
+    }
 
     // accept any open emergency access invitations
     if !CONFIG.mail_enabled() && CONFIG.emergency_access_allowed() {
@@ -639,41 +630,9 @@ pub async fn register(data: Json<RegisterData>, conn: DbConn) -> JsonResult {
     })))
 }
 
-/// Upstream's shape checks of the set-password body, on the raw JSON that the untagged compat would hide.
-///
-/// Ref: <https://github.com/bitwarden/server/blob/9030c42bf7d8f9ac2ff9fee85c39588d5eb81499/src/Api/Auth/Models/Request/Accounts/SetInitialPasswordRequestModel.cs#L75-L106>
-fn validate_set_password_shape(body: &Value) -> EmptyResult {
-    let has = |name: &str| {
-        body.as_object().is_some_and(|o| o.iter().any(|(k, v)| k.eq_ignore_ascii_case(name) && !v.is_null()))
-    };
-
-    if has("accountKeys") && has("keys") {
-        err!("Cannot specify both AccountKeys and Keys. Provide exactly one keypair.")
-    }
-    let (authentication, unlock) = (has("masterPasswordAuthentication"), has("masterPasswordUnlock"));
-    if authentication != unlock {
-        err!(
-            "Must provide both MasterPasswordAuthentication and MasterPasswordUnlock together. Cannot provide one without the other."
-        )
-    }
-    if authentication && (has("masterPasswordHash") || has("key") || has("kdf")) {
-        err!(
-            "Cannot mix modern (MasterPasswordAuthentication/MasterPasswordUnlock) and legacy (MasterPasswordHash/Key/Kdf) fields. Provide one shape or the other."
-        )
-    }
-    Ok(())
-}
-
 #[post("/accounts/set-password", data = "<data>")]
-async fn post_set_password(data: Json<Value>, headers: Headers, conn: DbConn) -> JsonResult {
-    let data = data.into_inner();
-    validate_set_password_shape(&data)?;
-    let Ok(data) = serde_json::from_value::<SetPasswordData>(data) else {
-        err_code!("Unexpected SetPasswordData format", Status::UnprocessableEntity.code)
-    };
-    if data.master_password_hint.as_ref().is_some_and(|h| h.encode_utf16().count() > 50) {
-        err!("The field MasterPasswordHint must be a string with a maximum length of 50.")
-    }
+async fn post_set_password(data: Json<SetPasswordData>, headers: Headers, conn: DbConn) -> JsonResult {
+    let data: SetPasswordData = data.into_inner();
     let mut user = headers.user;
 
     if user.private_key.is_some() || !user.password_hash.is_empty() {
@@ -689,25 +648,7 @@ async fn post_set_password(data: Json<Value>, headers: Headers, conn: DbConn) ->
     let password_hint = clean_password_hint(data.master_password_hint.as_ref());
     enforce_password_hint_setting(password_hint.as_ref())?;
 
-    // Like upstream, `accountKeys` only through the v2 JIT flow
-    // Ref: <https://github.com/bitwarden/server/blob/9030c42bf7d8f9ac2ff9fee85c39588d5eb81499/src/Api/Auth/Controllers/AccountsController.cs#L314-L359>
-    let account_keys = match data.account_keys {
-        Some(account_keys) => {
-            if !matches!(data.compat, RegisterDataCompat::RegisterDataCur(_))
-                || !crate::util::is_client_feature_flag_enabled(
-                    "enable-account-encryption-v2-jit-password-registration",
-                )
-            {
-                err!("Request includes V2 AccountKeys but V2 encryption is not enabled.")
-            }
-            let account_keys = account_keys.validate()?;
-            if !account_keys.is_v2() {
-                err!("AccountKeys are only supported for V2 encryption.")
-            }
-            Some(account_keys)
-        }
-        None => data.keys.map(ValidatedAccountKeys::from),
-    };
+    let account_keys = ValidatedAccountKeys::from_request(data.account_keys, data.keys)?;
 
     set_kdf_data(&mut user, data.compat.kdf())?;
 
@@ -871,9 +812,8 @@ async fn get_keys(headers: Headers, conn: DbConn) -> JsonResult {
 #[derive(Debug, Deserialize)]
 #[serde(rename_all = "camelCase")]
 struct PostKeysData {
-    // Required like upstream, even next to `accountKeys`
-    public_key: Option<String>,
-    encrypted_private_key: Option<String>,
+    #[serde(flatten)]
+    keys: Option<KeysData>,
     account_keys: Option<AccountKeysData>,
     // The id of the user key these account keys belong to, only honored for v2 `accountKeys`
     user_key_id: Option<KeyId>,
@@ -885,18 +825,15 @@ async fn post_keys(data: Json<PostKeysData>, headers: Headers, conn: DbConn) ->
 
     let mut user = headers.user;
 
-    // Only for an account without keys, replacing them is what a key rotation does
+    // This only sets the keys of an account that has none yet. Replacing existing ones is what a key
+    // rotation does, with the checks that go with it.
     if user.private_key.is_some() || user.public_key.is_some() {
         err!("User has existing keypair")
     }
 
-    // Ref: <https://github.com/bitwarden/server/blob/9030c42bf7d8f9ac2ff9fee85c39588d5eb81499/src/Core/Auth/Models/Api/Request/Accounts/KeysRequestModel.cs#L11-L19>
-    let public_key = required(data.public_key, "PublicKey")?;
-    let encrypted_private_key = required(data.encrypted_private_key, "EncryptedPrivateKey")?;
-
-    // `accountKeys` supersedes the flat keys when both are sent
-    let account_keys = match data.account_keys {
-        Some(account_keys) => {
+    // `accountKeys` supersedes the flat `keys` object when both are sent.
+    let account_keys = match (data.account_keys, data.keys) {
+        (Some(account_keys), _) => {
             let account_keys = account_keys.validate()?;
             if !account_keys.is_v2() {
                 err!("AccountKeys are only supported for V2 encryption.")
@@ -907,11 +844,8 @@ async fn post_keys(data: Json<PostKeysData>, headers: Headers, conn: DbConn) ->
             }
             account_keys
         }
-        None => KeysData {
-            encrypted_private_key,
-            public_key,
-        }
-        .into(),
+        (None, Some(keys)) => keys.into(),
+        (None, None) => err!("No account keys provided"),
     };
 
     account_keys.apply(&mut user)?;
@@ -1055,9 +989,11 @@ struct UnlockData {
     contained_key_id: Option<KeyId>,
 }
 
-/// A password or KDF change keeps the user key, so its key id must be the current one, when both are known.
+/// A password or KDF change re-wraps the same user key, so a key id sent with it has to be the
+/// current one. Either may be missing: from a client that predates key ids, or a user whose key id
+/// isn't known yet. There is nothing to compare in those cases.
 ///
-/// Ref: <https://github.com/bitwarden/server/blob/9030c42bf7d8f9ac2ff9fee85c39588d5eb81499/src/Core/KeyManagement/Models/Data/MasterPasswordUnlockData.cs#L27-L47>
+/// Ref: <https://github.com/bitwarden/server/blob/main/src/Core/KeyManagement/Models/Data/MasterPasswordUnlockData.cs>
 fn validate_key_id_unchanged(user: &User, unlock_data: &UnlockData) -> EmptyResult {
     if let (Some(current), Some(contained)) = (&user.key_id, &unlock_data.contained_key_id)
         && current != contained
@@ -1268,7 +1204,9 @@ async fn post_rotatekey(data: Json<KeyData>, headers: Headers, conn: DbConn, nt:
         err!("Invalid password")
     }
 
-    // Rotating v2 keys, or upgrading to them, would leave an account that can't be unlocked here
+    // This only rotates the keys of a v1 account. A v2 account's signing key would stay wrapped by the
+    // old user key, and a v1 account can't be upgraded here, since the signature key pair isn't read.
+    // Either would leave an account that can't be unlocked.
     if headers.user.is_v2() {
         err!("Key rotation is not supported for v2 accounts")
     }

src/api/core/ciphers.rs

@@ -197,7 +197,7 @@ async fn sync(data: SyncData, headers: Headers, client_version: Option<ClientVer
         Value::Null
     };
 
-    // Upstream omits these when unset rather than sending null
+    // Upstream omits this when unset rather than sending null.
     let mut user_decryption = json!({ "masterPasswordUnlock": master_password_unlock });
     if let Some(key_id) = &headers.user.key_id {
         user_decryption["userKeyId"] = json!(key_id);
@@ -274,8 +274,7 @@ pub struct CipherData {
 
     key: Option<String>,
 
-    // Added in web-v2025.6.0. Deprecated upstream for `encrypted_by_key_id`, but still checked when sent
-    pub encrypted_for: Option<UserId>,
+    pub encrypted_for: UserId, // Added in web-v2025.6.0
     // Added in web-v2025.8.1, Optional for compat
     pub encrypted_by_key_id: Option<KeyId>,
 
@@ -342,22 +341,12 @@ impl From<CipherValidationError> for crate::Error {
     }
 }
 
-/// The cipher must have been encrypted for the acting user. Only checked when the client sends the field.
+/// A user-owned cipher must be encrypted with the user's current key. Organization ciphers use the
+/// organization key, which has no id yet, and either id may be missing: from a client that predates
+/// the field, or a user whose key id isn't known yet. There is nothing to compare in those cases.
 ///
-/// Ref: <https://github.com/bitwarden/server/blob/9030c42bf7d8f9ac2ff9fee85c39588d5eb81499/src/Api/Vault/Controllers/CiphersController.cs#L1857-L1870>
-fn validate_encrypted_for_user(data: &CipherData, user_id: &UserId) -> EmptyResult {
-    if data.encrypted_for.as_ref().is_some_and(|encrypted_for| encrypted_for != user_id) {
-        err!("Cipher was not encrypted for the current user. Please try again.")
-    }
-    Ok(())
-}
-
-/// [`validate_encrypted_for_user`], plus the key id of a user-owned cipher, when both ids are known.
-///
-/// Ref: <https://github.com/bitwarden/server/blob/9030c42bf7d8f9ac2ff9fee85c39588d5eb81499/src/Api/Vault/Controllers/CiphersController.cs#L1886-L1911>
-fn validate_encrypted_by_user(data: &CipherData, user: &User, is_org_cipher: bool) -> EmptyResult {
-    validate_encrypted_for_user(data, &user.uuid)?;
-
+/// Ref: upstream's `CiphersController.ValidateCipherEncryptedByUser`
+fn validate_encrypted_by_user_key(data: &CipherData, user: &User, is_org_cipher: bool) -> EmptyResult {
     if !is_org_cipher
         && let (Some(cipher_key_id), Some(user_key_id)) = (&data.encrypted_by_key_id, &user.key_id)
         && cipher_key_id != user_key_id
@@ -371,15 +360,16 @@ fn validate_encrypted_by_user(data: &CipherData, user: &User, is_org_cipher: boo
 const MAX_CIPHER_DATA_LENGTH: usize = 500_000;
 
 impl CipherData {
-    /// Whether `data` is a blob rather than the per-type fields. Parses `data`, so keep the result.
+    /// Whether the content is a single blob rather than the per-type fields. This parses `data`, so
+    /// callers that need the answer more than once should keep it.
     pub fn is_blob(&self) -> bool {
         self.data.as_deref().is_some_and(is_data_blob_encrypted)
     }
 
-    /// Upstream's model checks that depend on the format: the size of `data`, and a name unless it's a blob.
+    /// Checks the content the way upstream's model validation does, before anything is saved.
+    /// `is_blob` is [`Self::is_blob`].
     ///
-    /// Ref: <https://github.com/bitwarden/server/blob/9030c42bf7d8f9ac2ff9fee85c39588d5eb81499/src/Api/Vault/Models/Request/CipherRequestModel.cs#L76-L77>
-    /// and <https://github.com/bitwarden/server/blob/9030c42bf7d8f9ac2ff9fee85c39588d5eb81499/src/Api/Vault/Models/Request/CipherRequestModel.cs#L91-L99>
+    /// Ref: <https://github.com/bitwarden/server/blob/main/src/Api/Vault/Models/Request/CipherRequestModel.cs>
     pub fn validate_content(&self, is_blob: bool) -> Result<(), CipherValidationError> {
         if let Some(data) = &self.data
             && data.len() > MAX_CIPHER_DATA_LENGTH
@@ -435,14 +425,17 @@ async fn post_ciphers_create(
 ) -> JsonResult {
     let mut data: ShareCipherData = data.into_inner();
 
-    validate_encrypted_by_user(&data.cipher, &headers.user, data.cipher.organization_id.is_some())?;
+    if data.cipher.encrypted_for != headers.user.uuid {
+        err_code!("Invalid user cipher", Status::UnprocessableEntity.code);
+    }
+    validate_encrypted_by_user_key(&data.cipher, &headers.user, data.cipher.organization_id.is_some())?;
 
     // This check is usually only needed in update_cipher_from_data(), but we
     // need it here as well to avoid creating an empty cipher in the call to
     // cipher.save() below.
     enforce_personal_ownership_policy(Some(&data.cipher), &headers, &conn).await?;
 
-    let mut cipher = Cipher::new(data.cipher.r#type);
+    let mut cipher = Cipher::new(data.cipher.r#type, String::new());
     cipher.user_uuid = Some(headers.user.uuid.clone());
     cipher.save(&conn).await?;
 
@@ -466,7 +459,11 @@ async fn post_ciphers_create(
 async fn post_ciphers(data: Json<CipherData>, headers: Headers, conn: DbConn, nt: Notify<'_>) -> JsonResult {
     let mut data: CipherData = data.into_inner();
 
-    validate_encrypted_by_user(&data, &headers.user, data.organization_id.is_some())?;
+    if data.encrypted_for != headers.user.uuid {
+        err_code!("Invalid user cipher", Status::UnprocessableEntity.code);
+    }
+
+    validate_encrypted_by_user_key(&data, &headers.user, data.organization_id.is_some())?;
 
     // The web/browser clients set this field to null as expected, but the
     // mobile clients seem to set the invalid value `0001-01-01T00:00:00`,
@@ -474,7 +471,7 @@ async fn post_ciphers(data: Json<CipherData>, headers: Headers, conn: DbConn, nt
     // needed when creating a new cipher, so just ignore it unconditionally.
     data.last_known_revision_date = None;
 
-    let mut cipher = Cipher::new(data.r#type);
+    let mut cipher = Cipher::new(data.r#type, String::new());
     update_cipher_from_data(&mut cipher, data, &headers, None, &conn, &nt, UpdateType::SyncCipherCreate).await?;
 
     Ok(Json(cipher.to_json(&headers.host, &headers.user.uuid, None, CipherSyncType::User, &conn).await?))
@@ -498,44 +495,6 @@ async fn enforce_personal_ownership_policy(data: Option<&CipherData>, headers: &
     Ok(())
 }
 
-/// The checks of saving a cipher, for callers that run them before writing anything else
-async fn validate_cipher_update(
-    cipher: &Cipher,
-    data: &CipherData,
-    headers: &Headers,
-    conn: &DbConn,
-    ut: UpdateType,
-) -> EmptyResult {
-    // Check that the client isn't updating an existing cipher with stale data.
-    // And only perform this check when not importing ciphers, else the date/time check will fail.
-    if ut != UpdateType::None
-        && let Some(dt) = &data.last_known_revision_date
-    {
-        match NaiveDateTime::parse_from_str(dt, "%+") {
-            // ISO 8601 format
-            Err(err) => warn!("Error parsing LastKnownRevisionDate '{dt}': {err}"),
-            Ok(dt) if cipher.updated_at.signed_duration_since(dt).num_seconds() > 1 => {
-                err!("The client copy of this cipher is out of date. Resync the client and try again.")
-            }
-            Ok(_) => (),
-        }
-    }
-
-    if let Some(note) = &data.notes {
-        let max_note_size = CONFIG._max_note_size();
-        if note.len() > max_note_size {
-            err!(format!("The field Notes exceeds the maximum encrypted value length of {max_note_size} characters."))
-        }
-    }
-
-    if let Some(folder_id) = &data.folder_id
-        && Folder::find_by_uuid_and_user(folder_id, &headers.user.uuid, conn).await.is_none()
-    {
-        err!("Invalid folder", "Folder does not exist or belongs to another user");
-    }
-    Ok(())
-}
-
 pub async fn update_cipher_from_data(
     cipher: &mut Cipher,
     data: CipherData,
@@ -563,12 +522,33 @@ pub async fn update_cipher_from_data(
 
     let is_blob = data.is_blob();
     data.validate_content(is_blob)?;
-    validate_cipher_update(cipher, &data, headers, conn, ut).await?;
+
+    // Check that the client isn't updating an existing cipher with stale data.
+    // And only perform this check when not importing ciphers, else the date/time check will fail.
+    if ut != UpdateType::None
+        && let Some(dt) = data.last_known_revision_date
+    {
+        match NaiveDateTime::parse_from_str(&dt, "%+") {
+            // ISO 8601 format
+            Err(err) => warn!("Error parsing LastKnownRevisionDate '{dt}': {err}"),
+            Ok(dt) if cipher.updated_at.signed_duration_since(dt).num_seconds() > 1 => {
+                err!("The client copy of this cipher is out of date. Resync the client and try again.")
+            }
+            Ok(_) => (),
+        }
+    }
 
     if cipher.organization_uuid.is_some() && cipher.organization_uuid != data.organization_id {
         err!("Organization mismatch. Please resync the client before updating the cipher")
     }
 
+    if let Some(note) = &data.notes {
+        let max_note_size = CONFIG._max_note_size();
+        if note.len() > max_note_size {
+            err!(format!("The field Notes exceeds the maximum encrypted value length of {max_note_size} characters."))
+        }
+    }
+
     // Check if this cipher is being transferred from a personal to an organization vault
     let transfer_cipher = cipher.organization_uuid.is_none() && data.organization_id.is_some();
 
@@ -599,6 +579,12 @@ pub async fn update_cipher_from_data(
         cipher.user_uuid = Some(headers.user.uuid.clone());
     }
 
+    if let Some(ref folder_id) = data.folder_id
+        && Folder::find_by_uuid_and_user(folder_id, &headers.user.uuid, conn).await.is_none()
+    {
+        err!("Invalid folder", "Folder does not exist or belongs to another user");
+    }
+
     // Modify attachments name and keys when rotating
     if let Some(attachments) = data.attachments2 {
         for (id, attachment) in attachments {
@@ -638,7 +624,8 @@ pub async fn update_cipher_from_data(
     };
 
     if let Some(blob) = data.data.filter(|_| is_blob) {
-        // A blob holds everything, the name included; the column can't be null, so it's left empty
+        // A blob holds all of the content, the name included, so nothing is kept outside it. The name
+        // column can't be null, so it's left empty; `to_json` reports it as null, as upstream does.
         // TODO: Make `ciphers.name` nullable and store `None` here instead.
         cipher.name = String::new();
         cipher.notes = None;
@@ -763,7 +750,7 @@ async fn post_ciphers_import(data: Json<ImportData>, headers: Headers, conn: DbC
         let folder_id = relations_map.get(&index).and_then(|i| folders.get(*i).cloned());
         cipher_data.folder_id = folder_id;
 
-        let mut cipher = Cipher::new(cipher_data.r#type);
+        let mut cipher = Cipher::new(cipher_data.r#type, String::new());
         update_cipher_from_data(&mut cipher, cipher_data, &headers, None, &conn, &nt, UpdateType::None).await?;
     }
 
@@ -831,8 +818,7 @@ async fn put_cipher(
         err!("Cipher is not write accessible")
     }
 
-    // Against the cipher we hold rather than the organization the client claims, like upstream
-    validate_encrypted_by_user(&data, &headers.user, cipher.organization_uuid.is_some())?;
+    validate_encrypted_by_user_key(&data, &headers.user, cipher.organization_uuid.is_some())?;
 
     update_cipher_from_data(&mut cipher, data, &headers, None, &conn, &nt, UpdateType::SyncCipherUpdate).await?;
 
@@ -1092,7 +1078,9 @@ async fn post_cipher_share(
     conn: DbConn,
     nt: Notify<'_>,
 ) -> JsonResult {
-    put_cipher_share(cipher_id, data, headers, conn, nt).await
+    let data: ShareCipherData = data.into_inner();
+
+    share_cipher_by_uuid(&cipher_id, data, &headers, &conn, &nt, None).await
 }
 
 #[put("/ciphers/<cipher_id>/share", data = "<data>")]
@@ -1105,21 +1093,6 @@ async fn put_cipher_share(
 ) -> JsonResult {
     let data: ShareCipherData = data.into_inner();
 
-    // Upstream's `PutShare` checks, before anything is written.
-    // Ref: <https://github.com/bitwarden/server/blob/9030c42bf7d8f9ac2ff9fee85c39588d5eb81499/src/Api/Vault/Controllers/CiphersController.cs#L899-L912>
-    // and <https://github.com/bitwarden/server/blob/9030c42bf7d8f9ac2ff9fee85c39588d5eb81499/src/Api/Vault/Models/Request/CipherRequestModel.cs#L498-L519>
-    if data.cipher.organization_id.is_none() {
-        err!("Cipher OrganizationId is required.")
-    }
-    if data.collection_ids.is_empty() {
-        err!("You must select at least one collection.")
-    }
-    if !Cipher::find_by_uuid(&cipher_id, &conn).await.is_some_and(|c| c.user_uuid.as_ref() == Some(&headers.user.uuid))
-    {
-        err_code!("Cipher doesn't exist", Status::NotFound.code)
-    }
-    validate_encrypted_for_user(&data.cipher, &headers.user.uuid)?;
-
     share_cipher_by_uuid(&cipher_id, data, &headers, &conn, &nt, None).await
 }
 
@@ -1139,33 +1112,18 @@ async fn put_cipher_share_selected(
 ) -> EmptyResult {
     let mut data: ShareSelectedCipherData = data.into_inner();
 
-    // Upstream's `PutShareMany` checks, before anything is written.
-    // Ref: <https://github.com/bitwarden/server/blob/9030c42bf7d8f9ac2ff9fee85c39588d5eb81499/src/Api/Vault/Controllers/CiphersController.cs#L1395-L1421>
-    // and <https://github.com/bitwarden/server/blob/9030c42bf7d8f9ac2ff9fee85c39588d5eb81499/src/Api/Vault/Models/Request/CipherRequestModel.cs#L560-L604>
     if data.ciphers.is_empty() {
         err!("You must select at least one cipher.")
     }
-    if data.ciphers.iter().any(|c| c.id.is_none() || c.organization_id.is_none()) {
-        err!("All Ciphers must have an Id and OrganizationId.")
-    }
-    if data.ciphers.iter().map(|c| &c.organization_id).collect::<HashSet<_>>().len() != 1 {
-        err!("All ciphers must be for the same organization.")
-    }
+
     if data.collection_ids.is_empty() {
         err!("You must select at least one collection.")
     }
+
     for cipher in &data.ciphers {
-        cipher.validate_content(cipher.is_blob())?;
-    }
-    for cipher in &data.ciphers {
-        validate_encrypted_for_user(cipher, &headers.user.uuid)?;
-    }
-    let owned_ciphers = Cipher::find_owned_by_user(&headers.user.uuid, &conn).await;
-    for cipher_data in &data.ciphers {
-        let Some(cipher) = owned_ciphers.iter().find(|c| cipher_data.id.as_ref() == Some(&c.uuid)) else {
-            err!("Trying to share ciphers that you do not own.")
-        };
-        validate_cipher_update(cipher, cipher_data, &headers, &conn, UpdateType::None).await?;
+        if cipher.id.is_none() {
+            err!("Request missing ids field")
+        }
     }
 
     while let Some(cipher) = data.ciphers.pop() {
@@ -1212,20 +1170,6 @@ async fn share_cipher_by_uuid(
         err!("Organization mismatch. Please resync the client before updating the cipher")
     }
 
-    // When LastKnownRevisionDate is None, it is a new cipher, so send CipherCreate.
-    // If there is an override, like when handling multiple items, we want to prevent a push notification for every single item
-    let ut = if let Some(ut) = override_ut {
-        ut
-    } else if data.cipher.last_known_revision_date.is_some() {
-        UpdateType::SyncCipherUpdate
-    } else {
-        UpdateType::SyncCipherCreate
-    };
-
-    // For the same reason, the other checks of saving
-    data.cipher.validate_content(data.cipher.is_blob())?;
-    validate_cipher_update(&cipher, &data.cipher, headers, conn, ut).await?;
-
     let mut shared_to_collections = vec![];
 
     if let Some(organization_id) = &data.cipher.organization_id {
@@ -1244,6 +1188,16 @@ async fn share_cipher_by_uuid(
         }
     }
 
+    // When LastKnownRevisionDate is None, it is a new cipher, so send CipherCreate.
+    // If there is an override, like when handling multiple items, we want to prevent a push notification for every single item
+    let ut = if let Some(ut) = override_ut {
+        ut
+    } else if data.cipher.last_known_revision_date.is_some() {
+        UpdateType::SyncCipherUpdate
+    } else {
+        UpdateType::SyncCipherCreate
+    };
+
     update_cipher_from_data(&mut cipher, data.cipher, headers, Some(shared_to_collections), conn, nt, ut).await?;
 
     Ok(Json(cipher.to_json(&headers.host, &headers.user.uuid, None, CipherSyncType::User, conn).await?))

src/api/core/organizations.rs

@@ -8,7 +8,7 @@ use crate::{
     CONFIG,
     api::admin::FAKE_ADMIN_UUID,
     api::{
-        ApiResult, EmptyResult, JsonResult, Notify, PasswordOrOtpData, UpdateType,
+        EmptyResult, JsonResult, Notify, PasswordOrOtpData, UpdateType,
         core::{CipherSyncData, CipherSyncType, accept_org_invite, log_event, two_factor},
     },
     auth::{AdminHeaders, Headers, ManagerHeaders, ManagerHeadersLoose, OrgMemberHeaders, OwnerHeaders, decode_invite},
@@ -1829,7 +1829,7 @@ async fn post_org_import(
         cipher_data.folder_id = None;
         // Replace the client-provided, unvalidated organizationId with the real target org
         cipher_data.organization_id = Some(org_id.clone());
-        let mut cipher = Cipher::new(cipher_data.r#type);
+        let mut cipher = Cipher::new(cipher_data.r#type, String::new());
         update_cipher_from_data(
             &mut cipher,
             cipher_data,
@@ -2764,26 +2764,8 @@ struct OrganizationUserRecoverAccountRequest {
 // But the clients do not seem to use this at all
 // Just add it here in case they will
 #[get("/organizations/<org_id>/public-key")]
-async fn get_organization_public_key(
-    org_id: OrganizationId,
-    headers: Headers,
-    member: Result<OrgMemberHeaders, &'static str>,
-    conn: DbConn,
-) -> JsonResult {
-    // SSO users without an org get the fake one, whose key the v2 JIT password flow fetches anyway
-    if org_id.eq_ignore_ascii_case(FAKE_SSO_IDENTIFIER) && headers.user.private_key.is_none() {
-        return Ok(Json(json!({
-            "object": "organizationPublicKey",
-            "publicKey": fake_sso_org_public_key().await?,
-        })));
-    }
-    let member = match member {
-        Ok(member) => member,
-        // The guard already logged it
-        Err(e) => return Err(crate::error::Error::new_msg(e).with_code(Status::Unauthorized.code)),
-    };
-
-    if org_id != member.membership.org_uuid {
+async fn get_organization_public_key(org_id: OrganizationId, headers: OrgMemberHeaders, conn: DbConn) -> JsonResult {
+    if org_id != headers.membership.org_uuid {
         err!("Organization not found", "Organization id's do not match");
     }
     let Some(org) = Organization::find_by_uuid(&org_id, &conn).await else {
@@ -2796,30 +2778,11 @@ async fn get_organization_public_key(
     })))
 }
 
-/// The SDK only uses this key to wrap an account recovery key that it never sends for the fake org,
-/// so it is made once and its private half dropped.
-async fn fake_sso_org_public_key() -> ApiResult<String> {
-    static PUBLIC_KEY: std::sync::LazyLock<Option<String>> = std::sync::LazyLock::new(|| {
-        let der = openssl::rsa::Rsa::generate(2048).and_then(|rsa| rsa.public_key_to_der()).ok()?;
-        Some(data_encoding::BASE64.encode(&der))
-    });
-
-    let Ok(Some(public_key)) = tokio::task::spawn_blocking(|| PUBLIC_KEY.clone()).await else {
-        err!("Failed to generate the organization key")
-    };
-    Ok(public_key)
-}
-
 // Obsolete - Renamed to public-key (2023.8), left for backwards compatibility with older clients
 // https://github.com/bitwarden/server/blob/9ebe16587175b1c0e9208f84397bb75d0d595510/src/Api/AdminConsole/Controllers/OrganizationsController.cs#L487-L492
 #[get("/organizations/<org_id>/keys")]
-async fn get_organization_keys(
-    org_id: OrganizationId,
-    headers: Headers,
-    member: Result<OrgMemberHeaders, &'static str>,
-    conn: DbConn,
-) -> JsonResult {
-    get_organization_public_key(org_id, headers, member, conn).await
+async fn get_organization_keys(org_id: OrganizationId, headers: OrgMemberHeaders, conn: DbConn) -> JsonResult {
+    get_organization_public_key(org_id, headers, conn).await
 }
 
 // Will allow to reset 2FA too

src/config.rs

@@ -1424,8 +1424,8 @@ pub const SUPPORTED_FEATURE_FLAGS: &[&str] = &[
     "ssh-agent-v2",
     // Key Management Team
     "windows-native-credential-sync",
-    "enable-account-encryption-v2-jit-password-registration",
     "pm-27278-v2-password-registration",
+    "enable-account-encryption-v2-jit-password-registration",
     // Mobile Team
     "pm-34171-card-scanner",
     // Platform Team

src/db/models/cipher.rs

@@ -19,7 +19,7 @@ use crate::{
         },
     },
     error::MapResult,
-    util::{LowerCase, convert_json_key_lcase_first},
+    util::LowerCase,
 };
 use macros::UuidFromParam;
 
@@ -63,9 +63,13 @@ pub struct Cipher {
     pub reprompt: Option<i32>,
 }
 
-/// Whether `data` is a v2 cipher blob, recognized like upstream by a top-level `format_version` key.
+/// Whether `data` is a sealed cipher blob rather than the legacy per-type JSON.
 ///
-/// Ref: <https://github.com/bitwarden/server/blob/9030c42bf7d8f9ac2ff9fee85c39588d5eb81499/src/Core/Vault/Entities/Cipher.cs#L36-L41>
+/// Ciphers of v2 accounts are encrypted as a single blob that carries everything, name included,
+/// and is opaque to us. It is recognized the same way upstream does, by a top-level
+/// `format_version` key that the legacy JSON never has.
+///
+/// Ref: <https://github.com/bitwarden/server/blob/main/src/Core/Vault/Entities/Cipher.cs>
 pub fn is_data_blob_encrypted(data: &str) -> bool {
     serde_json::from_str::<Value>(data).is_ok_and(|d| is_blob_value(&d))
 }
@@ -82,8 +86,7 @@ pub enum RepromptType {
 
 /// Local methods
 impl Cipher {
-    /// The name is set when the data is saved, since a blob-encrypted cipher has it inside `data`
-    pub fn new(atype: i32) -> Self {
+    pub fn new(atype: i32, name: String) -> Self {
         let now = Utc::now().naive_utc();
 
         Self {
@@ -97,7 +100,7 @@ impl Cipher {
             key: None,
 
             atype,
-            name: String::new(),
+            name,
 
             notes: None,
             fields: None,
@@ -172,8 +175,9 @@ impl Cipher {
     ) -> Result<Value, crate::Error> {
         use crate::util::{format_date, validate_and_format_date};
 
-        // Parsed once, since `data` can be large and this runs for every cipher in a sync
-        let type_data = serde_json::from_str::<Value>(&self.data);
+        // Parsed once here, since `data` can be large and this runs for every cipher in a sync.
+        // `LowerCase` only lowercases the first letter of each key, so it keeps `format_version`.
+        let type_data = serde_json::from_str::<LowerCase<Value>>(&self.data).map(|d| d.data);
         let is_blob_encrypted = type_data.as_ref().is_ok_and(is_blob_value);
 
         let mut attachments_json: Value = Value::Null;
@@ -211,70 +215,62 @@ impl Cipher {
             (false, false, false)
         };
 
-        let fields_json: Vec<_> = self
-            .fields
-            .as_ref()
-            .and_then(|s| {
-                serde_json::from_str::<Vec<LowerCase<Value>>>(s)
-                    .inspect_err(|e| warn!("Error parsing fields {e:?} for {}", self.uuid))
-                    .ok()
-            })
-            .map(|d| {
-                d.into_iter()
-                    .map(|mut f| {
-                        // Check if the `type` key is a number, strings break some clients
-                        // The fallback type is the hidden type `1`. this should prevent accidental data disclosure
-                        // If not try to convert the string value to a number and fallback to `1`
-                        // If it is both not a number and not a string, fallback to `1`
-                        match f.data.get("type") {
-                            Some(t) if t.is_number() => {}
-                            Some(t) if t.is_string() => {
-                                let type_num = &t.as_str().unwrap_or("1").parse::<u8>().unwrap_or(1);
-                                f.data["type"] = json!(type_num);
+        // Like upstream, a cipher that was stored without fields or password history reports them as
+        // null rather than as an empty list; clients keep the two apart.
+        let fields_json: Option<Vec<_>> = self.fields.as_ref().map(|s| {
+            serde_json::from_str::<Vec<LowerCase<Value>>>(s)
+                .inspect_err(|e| warn!("Error parsing fields {e:?} for {}", self.uuid))
+                .ok()
+                .map(|d| {
+                    d.into_iter()
+                        .map(|mut f| {
+                            // Check if the `type` key is a number, strings break some clients
+                            // The fallback type is the hidden type `1`. this should prevent accidental data disclosure
+                            // If not try to convert the string value to a number and fallback to `1`
+                            // If it is both not a number and not a string, fallback to `1`
+                            match f.data.get("type") {
+                                Some(t) if t.is_number() => {}
+                                Some(t) if t.is_string() => {
+                                    let type_num = &t.as_str().unwrap_or("1").parse::<u8>().unwrap_or(1);
+                                    f.data["type"] = json!(type_num);
+                                }
+                                _ => {
+                                    f.data["type"] = json!(1);
+                                }
                             }
-                            _ => {
-                                f.data["type"] = json!(1);
-                            }
-                        }
-                        f.data
-                    })
-                    .collect()
-            })
-            .unwrap_or_default();
+                            f.data
+                        })
+                        .collect()
+                })
+                .unwrap_or_default()
+        });
 
-        let password_history_json: Vec<_> = self
-            .password_history
-            .as_ref()
-            .and_then(|s| {
-                serde_json::from_str::<Vec<LowerCase<Value>>>(s)
-                    .inspect_err(|e| warn!("Error parsing password history {e:?} for {}", self.uuid))
-                    .ok()
-            })
-            .map(|d| {
-                // Check every password history item if they are valid and return it.
-                // If a password field has the type `null` skip it, it breaks newer Bitwarden clients
-                // A second check is done to verify the lastUsedDate exists and is a valid DateTime string, if not the epoch start time will be used
-                d.into_iter()
-                    .filter_map(|d| match d.data.get("password") {
-                        Some(p) if p.is_string() => Some(d.data),
-                        _ => None,
-                    })
-                    .map(|mut d| {
-                        let lud = if let Some(l) = d.get("lastUsedDate").and_then(|l| l.as_str()) {
-                            validate_and_format_date(l)
-                        } else {
-                            "1970-01-01T00:00:00.000000Z".to_owned()
-                        };
-                        d["lastUsedDate"] = json!(lud);
-                        d
-                    })
-                    .collect()
-            })
-            .unwrap_or_default();
-
-        // Like upstream, fields and password history stored as NULL are sent as null, not `[]`
-        let fields_json = self.fields.is_some().then_some(fields_json);
-        let password_history_json = self.password_history.is_some().then_some(password_history_json);
+        let password_history_json: Option<Vec<_>> = self.password_history.as_ref().map(|s| {
+            serde_json::from_str::<Vec<LowerCase<Value>>>(s)
+                .inspect_err(|e| warn!("Error parsing password history {e:?} for {}", self.uuid))
+                .ok()
+                .map(|d| {
+                    // Check every password history item if they are valid and return it.
+                    // If a password field has the type `null` skip it, it breaks newer Bitwarden clients
+                    // A second check is done to verify the lastUsedDate exists and is a valid DateTime string, if not the epoch start time will be used
+                    d.into_iter()
+                        .filter_map(|d| match d.data.get("password") {
+                            Some(p) if p.is_string() => Some(d.data),
+                            _ => None,
+                        })
+                        .map(|mut d| {
+                            let lud = if let Some(l) = d.get("lastUsedDate").and_then(|l| l.as_str()) {
+                                validate_and_format_date(l)
+                            } else {
+                                "1970-01-01T00:00:00.000000Z".to_owned()
+                            };
+                            d["lastUsedDate"] = json!(lud);
+                            d
+                        })
+                        .collect()
+                })
+                .unwrap_or_default()
+        });
 
         let collection_ids = if let Some(cipher_sync_data) = cipher_sync_data {
             if let Some(cipher_collections) = cipher_sync_data.cipher_collections.get(&self.uuid) {
@@ -372,7 +368,8 @@ impl Cipher {
         };
 
         if is_blob_encrypted {
-            // Like upstream, sent as-is with the structured fields null
+            // The blob holds all of the content, so it is sent back as-is and the structured fields
+            // stay null, as upstream does. Only the name needs clearing, the others are never stored.
             json_object["data"] = json!(self.data);
             json_object["name"] = Value::Null;
         } else {
@@ -381,18 +378,16 @@ impl Cipher {
         Ok(json_object)
     }
 
-    /// The per-type data of a legacy cipher, with fixups for values known to break clients.
+    /// The per-type data (`login`, `card`, …) of a legacy cipher, from `type_data` as parsed from
+    /// `self.data`, with fixups for values that are known to break clients.
     fn legacy_type_data_json(&self, type_data: Result<Value, serde_json::Error>) -> Value {
         use crate::util::validate_and_format_date;
 
         // Get the type_data or a default to an empty json object '{}'.
         // If not passing an empty object, mobile clients will crash.
-        let mut type_data_json = if let Ok(data @ Value::Object(_)) = type_data {
-            convert_json_key_lcase_first(data)
-        } else {
-            warn!("Error parsing data field for {}", self.uuid);
-            Value::Object(serde_json::Map::new())
-        };
+        let mut type_data_json = type_data
+            .inspect_err(|_| warn!("Error parsing data field for {}", self.uuid))
+            .unwrap_or_else(|_| Value::Object(serde_json::Map::new()));
 
         // NOTE: This was marked as *Backwards Compatibility Code*, but as of January 2021 this is still being used by upstream
         // Set the first element of the Uris array as Uri, this is needed several (mobile) clients.

src/db/models/user.rs

@@ -73,7 +73,8 @@ pub struct User {
 
     pub key_id: Option<KeyId>,
 
-    // The v2 state: all set, with a `user_signature_key_pairs` row, or none, see `User::is_v2`
+    // "v2" account cryptographic state. Either all of these are set (together with a row in
+    // `user_signature_key_pairs`) or none of them are; see `User::is_v2`.
     pub signed_public_key: Option<String>,
     pub security_state: Option<String>,
     pub security_version: Option<i32>,
@@ -282,35 +283,34 @@ impl User {
         UserSignatureKeyPair::find_by_user(&self.uuid, conn).await
     }
 
-    /// The `accountKeys` object (upstream's `PrivateKeysResponseModel`), null without a key pair
     pub async fn account_keys_json(&self, conn: &DbConn) -> Value {
-        if self.private_key.is_some() {
-            let (signed_public_key, signature_key_pair, security_state) = match self.v2_signature_key_pair(conn).await {
-                Some(key_pair) => (
-                    json!(self.signed_public_key),
-                    key_pair.to_json(),
-                    json!({
-                        "securityState": self.security_state,
-                        "securityVersion": self.security_version,
-                    }),
-                ),
-                None => (Value::Null, Value::Null, Value::Null),
-            };
-
-            json!({
-                "publicKeyEncryptionKeyPair": {
-                    "wrappedPrivateKey": self.private_key,
-                    "publicKey": self.public_key,
-                    "signedPublicKey": signed_public_key,
-                    "object": "publicKeyEncryptionKeyPair",
-                },
-                "securityState": security_state,
-                "signatureKeyPair": signature_key_pair,
-                "object": "privateKeys"
-            })
-        } else {
-            Value::Null
+        if self.private_key.is_none() {
+            return Value::Null;
         }
+
+        let (signed_public_key, signature_key_pair, security_state) = match self.v2_signature_key_pair(conn).await {
+            Some(key_pair) => (
+                json!(self.signed_public_key),
+                key_pair.to_json(),
+                json!({
+                    "securityState": self.security_state,
+                    "securityVersion": self.security_version,
+                }),
+            ),
+            None => (Value::Null, Value::Null, Value::Null),
+        };
+
+        json!({
+            "publicKeyEncryptionKeyPair": {
+                "wrappedPrivateKey": self.private_key,
+                "publicKey": self.public_key,
+                "signedPublicKey": signed_public_key,
+                "object": "publicKeyEncryptionKeyPair",
+            },
+            "signatureKeyPair": signature_key_pair,
+            "securityState": security_state,
+            "object": "privateKeys"
+        })
     }
 
     pub async fn public_keys_json(&self, conn: &DbConn) -> Value {
@@ -612,7 +612,18 @@ pub struct UserId(String);
 )]
 #[deref(forward)]
 #[from(forward)]
-pub struct KeyId(String);
+pub struct KeyId(#[serde(deserialize_with = "deserialize_key_id")] String);
+
+/// Rejects a key id from a request that isn't 16 bytes as lowercase hex, as upstream's `[KeyId]` does.
+///
+/// Ref: <https://github.com/bitwarden/server/blob/main/src/Core/KeyManagement/Models/Data/KeyId.cs>
+fn deserialize_key_id<'de, D: serde::Deserializer<'de>>(deserializer: D) -> Result<String, D::Error> {
+    let key_id = <String as serde::Deserialize>::deserialize(deserializer)?;
+    if key_id.len() != 32 || !key_id.bytes().all(|b| matches!(b, b'0'..=b'9' | b'a'..=b'f')) {
+        return Err(serde::de::Error::custom("Key id must be a 32 character lowercase hex-encoded string."));
+    }
+    Ok(key_id)
+}
 
 impl SsoUser {
     pub async fn save(&self, conn: &DbConn) -> EmptyResult {

src/db/models/user_signature_key_pair.rs

@@ -12,9 +12,14 @@ use crate::{
 
 use super::UserId;
 
-/// A user's signature key pair, part of the v2 state, in its own table like upstream.
+/// A user's signature key pair, part of the "v2" account cryptographic state.
 ///
-/// Ref: <https://github.com/bitwarden/server/blob/9030c42bf7d8f9ac2ff9fee85c39588d5eb81499/src/Sql/dbo/KeyManagement/Tables/UserSignatureKeyPair.sql#L1-L15>
+/// Upstream keeps this in its own table rather than as columns on the user, with a unique index on
+/// the user id. The stated intent is to eventually keep superseded key pairs around (an `active`
+/// flag was sketched but not shipped), which is why this is modelled as a row with its own identity
+/// instead of a set of user attributes.
+///
+/// Ref: <https://github.com/bitwarden/server/blob/main/src/Sql/dbo/KeyManagement/Tables/UserSignatureKeyPair.sql>
 #[derive(Identifiable, Queryable, Insertable, AsChangeset, Selectable)]
 #[diesel(table_name = user_signature_key_pairs)]
 #[diesel(treat_none_as_null = true)]
@@ -33,7 +38,7 @@ pub struct UserSignatureKeyPair {
     pub updated_at: NaiveDateTime,
 }
 
-/// Ref: <https://github.com/bitwarden/server/blob/9030c42bf7d8f9ac2ff9fee85c39588d5eb81499/src/Core/KeyManagement/Enums/SignatureAlgorithm.cs#L6-L10>
+/// https://github.com/bitwarden/server/blob/main/src/Core/KeyManagement/Enums/SignatureAlgorithm.cs
 #[derive(Clone, Copy, Debug, PartialEq, Eq)]
 pub enum SignatureAlgorithm {
     Ed25519 = 0,

src/util.rs

@@ -839,12 +839,6 @@ pub fn parse_experimental_client_feature_flags(
         .collect()
 }
 
-/// Whether the admin enabled this supported client feature flag
-pub fn is_client_feature_flag_enabled(flag: &str) -> bool {
-    parse_experimental_client_feature_flags(&CONFIG.experimental_client_feature_flags(), &FeatureFlagFilter::ValidOnly)
-        .contains_key(flag)
-}
-
 /// TODO: This is extracted from IpAddr::is_global, which is unstable:
 /// https://doc.rust-lang.org/nightly/std/net/enum.IpAddr.html#method.is_global
 /// Remove once https://github.com/rust-lang/rust/issues/27709 is merged