From d7eeac4e859325a8513f8c8148482a5e0e1ef219 Mon Sep 17 00:00:00 2001
From: Martijn Laan <martijnlaan@gmail.com>
Date: Thu, 21 May 2020 05:02:23 +0200
Subject: [PATCH] Fix and improve Inno Setup manifest. (#424)

* Fix name.

* Fix Arch to be like all other manifests.

* Fix SilentWithProgress.

* Fix InstallerType to be like the example and all other manifests.

* Add MinOSVersion and ManifestVersion like the example.

* Remove ManifestVersion

Apparently the documentation at https://docs.microsoft.com/nl-nl/windows/package-manager/package/manifest?tabs=minschema%2Ccompschema is incorrect.

* Add missing switches and cleanup existing.
---
 manifests/JRSoftware/InnoSetup/6.0.4.yaml | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/manifests/JRSoftware/InnoSetup/6.0.4.yaml b/manifests/JRSoftware/InnoSetup/6.0.4.yaml
index 55de4aea9..077cbd93d 100644
--- a/manifests/JRSoftware/InnoSetup/6.0.4.yaml
+++ b/manifests/JRSoftware/InnoSetup/6.0.4.yaml
@@ -1,18 +1,22 @@
 Id: JRSoftware.InnoSetup
 Version: 6.0.4
-Name: InnoSetup
+Name: Inno Setup
 Publisher: JRSoftware
 License: Copyright (C) 1997-2020 Jordan Russell. All rights reserved. Portions Copyright (C) 2000-2019 Martijn Laan. All rights reserved.
 LicenseUrl: https://jrsoftware.org/files/is/license.txt
 AppMoniker: innosetup
+MinOSVersion: 6.0.0.0
 Tags: inno, setup
 Description: Inno Setup is a free installer for Windows programs by Jordan Russell and Martijn Laan. First introduced in 1997, Inno Setup today rivals and even surpasses many commercial installers in feature set and stability.
 Homepage: https://jrsoftware.org/isinfo.php
+InstallerType: Inno
 Installers:
-  - Arch: x86
+  - Arch: x64
     Url: http://files.jrsoftware.org/is/6/innosetup-6.0.4.exe
     Sha256: 36963503278310FB2FF0DEB70DE4A49CDE0082B4DE4D79B66C45DF85BBC5F710
-    InstallerType: Inno
     Switches:
-      Silent: "/VERYSILENT /ALLUSERS"
-      SilentWithProgress: "/VERYSILENT /ALLUSERS"
\ No newline at end of file
+      InstallLocation: /DIR="<INSTALLPATH>"
+      Language: /LANG=<LANGUAGE>
+      Log: /LOG="<LOGPATH>"
+      Silent: /VERYSILENT /ALLUSERS
+      SilentWithProgress: /SILENT /ALLUSERS