Update KDF Configuration and processing

- Change default Password Hash KDF Storage from 100_000 to 600_000 iterations
- Update Password Hash when the default iteration value is different
- Validate password_iterations
- Validate client-side KDF to prevent it from being set lower than 100_000
This commit is contained in:
BlackDex
2023-01-24 13:06:31 +01:00
parent 9b7e86efc2
commit 2d8c8e18f7
6 changed files with 35 additions and 15 deletions

View File

@@ -161,7 +161,7 @@ pub async fn _register(data: JsonUpcase<RegisterData>, mut conn: DbConn) -> Json
user.client_kdf_type = client_kdf_type;
}
user.set_password(&data.MasterPasswordHash, None);
user.set_password(&data.MasterPasswordHash, true, None);
user.akey = data.Key;
user.password_hint = password_hint;
@@ -318,6 +318,7 @@ async fn post_password(
user.set_password(
&data.NewMasterPasswordHash,
true,
Some(vec![String::from("post_rotatekey"), String::from("get_contacts"), String::from("get_public_keys")]),
);
user.akey = data.Key;
@@ -348,9 +349,13 @@ async fn post_kdf(data: JsonUpcase<ChangeKdfData>, headers: Headers, mut conn: D
err!("Invalid password")
}
if data.KdfIterations < 100_000 {
err!("KDF iterations lower then 100000 are not allowed.")
}
user.client_kdf_iter = data.KdfIterations;
user.client_kdf_type = data.Kdf;
user.set_password(&data.NewMasterPasswordHash, None);
user.set_password(&data.NewMasterPasswordHash, true, None);
user.akey = data.Key;
let save_result = user.save(&mut conn).await;
@@ -560,7 +565,7 @@ async fn post_email(
user.email_new = None;
user.email_new_token = None;
user.set_password(&data.NewMasterPasswordHash, None);
user.set_password(&data.NewMasterPasswordHash, true, None);
user.akey = data.Key;
let save_result = user.save(&mut conn).await;

View File

@@ -662,7 +662,7 @@ async fn password_emergency_access(
};
// change grantor_user password
grantor_user.set_password(new_master_password_hash, None);
grantor_user.set_password(new_master_password_hash, true, None);
grantor_user.akey = key;
grantor_user.save(&mut conn).await?;

View File

@@ -130,7 +130,7 @@ async fn _password_login(
// Get the user
let username = data.username.as_ref().unwrap().trim();
let user = match User::find_by_mail(username, conn).await {
let mut user = match User::find_by_mail(username, conn).await {
Some(user) => user,
None => err!("Username or password is incorrect. Try again", format!("IP: {}. Username: {}.", ip.ip, username)),
};
@@ -150,6 +150,16 @@ async fn _password_login(
)
}
// Change the KDF Iterations
if user.password_iterations != CONFIG.password_iterations() {
user.password_iterations = CONFIG.password_iterations();
user.set_password(password, false, None);
if let Err(e) = user.save(conn).await {
error!("Error updating user: {:#?}", e);
}
}
// Check if the user is disabled
if !user.enabled {
err!(
@@ -172,7 +182,6 @@ async fn _password_login(
if resend_limit == 0 || user.login_verify_count < resend_limit {
// We want to send another email verification if we require signups to verify
// their email address, and we haven't sent them a reminder in a while...
let mut user = user;
user.last_verifying_at = Some(now);
user.login_verify_count += 1;